Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires exactly 1 or 3 arguments, got 2 #33

Open
Moelf opened this issue Jan 28, 2023 · 3 comments
Open

requires exactly 1 or 3 arguments, got 2 #33

Moelf opened this issue Jan 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Moelf
Copy link

Moelf commented Jan 28, 2023

Sometimes the type is only interpreted as sign or not signed, in that case I try to use something like

@define_integers 32 _ Index32

but then it errors because _ = is illegal

all-underscore identifier used as rvalue around /home/akako/.julia/packages/BitIntegers/6M5fx/src/BitIntegers.jl:60

I think we can maybe add a special case for _ to ignore it

@rfourquet
Copy link
Owner

Sounds like a goode idea.

@rfourquet rfourquet added the enhancement New feature or request label May 16, 2023
@Moelf
Copy link
Author

Moelf commented May 16, 2023

I will make a PR

@PatrickHaecker
Copy link

I would prefer having @define_signed_integer and @define_unsigned_integer in addition to @define_integers. Internally they could share most of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants