fix: skip additional empty line in MassBank export

- Drop the extra empty line in MassBank exports (issue #49).
rformassspectrometry · Oct 31, 2023 · c86c35d · c86c35d
1 parent f090674
commit c86c35d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/check-bioc.yml b/.github/workflows/check-bioc.yml
@@ -52,9 +52,9 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - { os: ubuntu-latest, r: 'devel', bioc: '3.17', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest" }
-          - { os: macOS-latest, r: 'next', bioc: '3.17'}
-          - { os: windows-latest, r: 'next', bioc: '3.17'}
+          - { os: ubuntu-latest, r: 'devel', bioc: '3.19', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest" }
+          - { os: macOS-latest, r: 'next', bioc: '3.19'}
+          - { os: windows-latest, r: 'next', bioc: '3.19'}
     env:
       R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
       RSPM: ${{ matrix.config.rspm }}

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: MsBackendMassbank
 Title: Mass Spectrometry Data Backend for MassBank record Files
-Version: 1.11.0
+Version: 1.11.1
 Authors@R:
     c(person(given = "RforMassSpectrometry Package Maintainer",
              email = "maintainer@rformassspectrometry.org",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,10 @@
+# MsBackendMassbank 1.11
+
+## Changes in 1.11.1
+
+- Remove additional empty line at the end of exported MassBank records ([issue
+  #49](https://github.com/rformassspectrometry/MsBackendMassbank/issues/49)).
+
 # MsBackendMassbank 1.7
 
 ## Changes in 1.7.4

diff --git a/R/functions-massbank.R b/R/functions-massbank.R
@@ -627,7 +627,7 @@ metaDataBlocks <- function() {
                     as.integer(peaksData(x[i])[[1]][,2] /
                                max(peaksData(x[i])[[1]][,2]) * 999),
                     collapse = "\n"))
-        .cat("\n//\n\n")
+        .cat("\n//\n")
     }
 }