Release v5.0.0

[infra-monkey]

I opened this discussion to discuss blocking points before releasing v5.0.0.

I'm doing some deeper test both upgrading from v4.4.6 and using v5.

So here is my first finding:
In resource freeipa_dns_zone there was a typo in the attribute allow_prt_sync, in v5 I have renamed it allow_ptr_sync in order to match the attribute name in freeipa.
Therefore, upgrade from 4.4.6 to 5.0.0 will fail if allow_prt_sync was previously set.

@RomanButsiy should I keep the typo in v5 in order to facilitate the upgrade and mark it as deprecated?
Or just keep it as is because managing both attributes is a mess with default values.

[RomanButsiy]

@infra-monkey I suggest keeping allow_ptr_sync as is and adding a warning in the documentation. For example, in my projects, this attribute was never used

[infra-monkey]

I've reverted the attribute name.
I've also fixed some minor edge case issues.

[RomanButsiy]

@infra-monkey Here's a summary of two potential issues identified in the current implementation:

1. Incorrect Certificate Path Retrieval: The current code uses conf.CaCertificate.String() to retrieve the certificate path, which consistently leads to an error stating the path does not exist. To resolve this issue, replace conf.CaCertificate.String() with conf.CaCertificate.ValueString()

2. Environment Variables Not Used: The environment variables FREEIPA_HOST, FREEIPA_USERNAME, FREEIPA_PASSWORD, FREEIPA_INSECURE, and FREEIPA_CA_CERT are defined but never actually utilized in the client creation process

[infra-monkey]

@RomanButsiy
Thank you for checking it out. Indeed I missed the certificate issue. I'll fix it.

[infra-monkey]

#56

[RomanButsiy]

@infra-monkey I've finished running additional tests and didn’t encounter any issues. Everything looks good to go! I think we're ready to release version v5.0.0.

[infra-monkey]

@RomanButsiy agreed.
I tested mostly the resource edition and didn't find issues on that part.
Looks good to me

[infra-monkey]

Closing the discussion as it has been released.