fixed: set Hangfire JobStorage early to prevent errors when calling i…

…t before its server starts, version bumped to 1.34.1
revoframework · Apr 4, 2023 · e2cd704 · e2cd704
1 parent fbc6467
commit e2cd704
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/Common.props b/Common.props
@@ -1,7 +1,7 @@
 <Project>
 
   <PropertyGroup>
-    <VersionPrefix>1.34.0</VersionPrefix>
+    <VersionPrefix>1.34.1</VersionPrefix>
   </PropertyGroup>
 
   <PropertyGroup>

diff --git a/Providers/AspNetCore/Revo.AspNetCore/Core/HangfireStartupConfigurator.cs b/Providers/AspNetCore/Revo.AspNetCore/Core/HangfireStartupConfigurator.cs
@@ -23,18 +23,19 @@ public void ConfigureServices(IServiceCollection services)
         {
             var storage = hangfireConfigurationSection.JobStorage();
 
+            // this needs to be set here, otherwise Hangfire throws error when enqueuing a job
+            // before IGlobalConfiguration has been first requested by the DI container
+            GlobalConfiguration.Configuration.UseStorage(storage);
+
             services
-                .AddHangfire(globalCfg =>
+                .AddHangfire(configuration =>
                 {
-                    globalCfg.UseStorage(storage);
-
+                    configuration.UseActivator(new HangfireJobActivator(kernel));
+                    
                     foreach (var action in hangfireConfigurationSection.ConfigurationActions)
                     {
-                        action(globalCfg);
+                        action(configuration);
                     }
-
-                    globalCfg.UseNLogLogProvider();
-                    globalCfg.UseActivator(new HangfireJobActivator(kernel));
                 });
 
             if (hangfireConfigurationSection.AddHangfireServer)

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,5 +1,10 @@
 # RELEASE NOTES
 
+## [1.34.1] - 2023-04-04
+
+### Fixed
+- set Hangfire JobStorage early to prevent errors when calling it before its server starts
+
 ## [1.34.0] - 2023-03-17
 
 ### Changed