Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to go 1.22 #182

Merged
merged 2 commits into from
May 2, 2024
Merged

Switch to go 1.22 #182

merged 2 commits into from
May 2, 2024

Conversation

retr0h
Copy link
Owner

@retr0h retr0h commented May 2, 2024 •
edited
Loading

  • Switched to go 1.22 and execute coverage with nocoverageredesign which seems to correct some buggy coverage reporting
  • Also pinned deps to @latest from arbitrary versions
  • Updated deprecated golangci config run.skip-dirs
  • go mod tidy
  • go install golangci-lint

Fixes: #179

retr0h
retr0h commented May 2, 2024
View reviewed changes
Taskfile.yml Show resolved Hide resolved
@retr0h retr0h added the v2.2.1 label May 2, 2024
@retr0h
fix: switch to go 1.22
ce55525 
* Switched to go 1.22 and execute coverage with nocoverageredesign
  which seems to correct some buggy coverage reporting
* Also pinned deps to @latest from arbitrary versions
* Updated deprecated golangci config `run.skip-dirs`
* go mod tidy

Fixes: #179
0xDEC0DE
0xDEC0DE suggested changes May 2, 2024
View reviewed changes
Taskfile.yml Outdated Show resolved Hide resolved
Taskfile.yml Show resolved Hide resolved
@retr0h retr0h merged commit 8a48e16 into main May 2, 2024
9 checks passed
@github-actions github-actions bot deleted the issue/179 branch May 2, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDEC0DE 0xDEC0DE 0xDEC0DE requested changes

Assignees
No one assigned
Labels
github/action kind/yaml v2.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with Go 1.22.2 drops coverage by ~25%
2 participants
@retr0h @0xDEC0DE