Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add /v2 prefix in to module in go.mod #146

Closed
wants to merge 2 commits into from
Closed

chore: add /v2 prefix in to module in go.mod #146

wants to merge 2 commits into from

Conversation

Jorropo
Copy link

@Jorropo Jorropo commented Feb 6, 2024 •
edited
Loading

Should fix golang/go#65539 and #145

0xDEC0DE
0xDEC0DE approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@0xDEC0DE 0xDEC0DE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, but I'm sure we'll want to try it first.

@0xDEC0DE
Copy link
Contributor

0xDEC0DE commented Feb 6, 2024

I'm pretty hopeful, though:

$ curl -sL https://proxy.golang.org/github.com/retr0h/gilt/v2/@latest
not found: github.com/retr0h/gilt/v2@v2.1.1: invalid version: go.mod has non-.../v2 module path "github.com/retr0h/gilt" (and .../v2/go.mod does not exist) at revision v2.1.1

@0xDEC0DE
Copy link
Contributor

0xDEC0DE commented Feb 6, 2024

Looks like this will require another release to take effect, though. The README.md should be updated as part of that chore, or bolted onto this PR.

@retr0h
Copy link
Owner

retr0h commented Feb 6, 2024

Looks like this will require another release to take effect, though. The README.md should be updated as part of that chore, or bolted onto this PR.

As in, update the install instructions, ya?

@0xDEC0DE
Copy link
Contributor

0xDEC0DE commented Feb 6, 2024

As in, update the install instructions, ya?

krekt

@0xDEC0DE
Copy link
Contributor

0xDEC0DE commented Feb 6, 2024

Well, this is unfortunate.

@retr0h
Copy link
Owner

retr0h commented Feb 6, 2024

Closing in favor of #148

@retr0h retr0h closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDEC0DE 0xDEC0DE 0xDEC0DE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxy.golang.org: github.com/retr0h/gilt
3 participants
@Jorropo @0xDEC0DE @retr0h