-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: publish wheels to testpypi #130
Conversation
Pushes binaries to testpypi on merge. Fixes: Issue #127
f90bca6
to
d1e767f
Compare
@@ -56,7 +56,7 @@ def __init__(self): | |||
with open("README.md") as f: | |||
self.readme = f.read() | |||
|
|||
self.distribution = self.metadata["project_name"] | |||
self.distribution = f"python-{self.metadata['project_name']}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be wise to double-check that the result files here are still installable, calling the package go-gilt
seemed to piss it off; this might do the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wont merge any of this without you verifying my hacks
@0xDEC0DE any ideas? Possibly name the wheels see: https://github.com/Bing-su/pip-binary-factory/blob/main/lazygit/build_wheel.py#L37C1-L38C1 |
You can't mix |
Although that change you linked seems to do it, so maybe... The docs I read seemed fairly confident it was a no-no, though. |
.goreleaser.yaml
Outdated
@@ -17,7 +17,7 @@ archives: | |||
checksum: | |||
name_template: 'checksums.txt' | |||
snapshot: | |||
name_template: "{{ incpatch .PreviousTag }}-dev+{{ .ShortCommit }}" | |||
name_template: "{{ incpatch .PreviousTag }}+dev.{{ .ShortCommit }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure you want Version
and not PreviousTag
. Leading v
is a bit of a no-no...
Damn it, I thought I verified that would work! angrily downloads a 32-bit Debian 12 VM |
What — and I cannot stress this part enough — the fuck |
Aha, it's banned: https://peps.python.org/pep-0513 |
OK:
I cannot find an ARM64 VM that will boot under VirtualBox, but I'll keep trying. |
Damn. Alpine strikes again:
|
We can skip ARM for the moment and solve that after ? |
This whole thing is becoming more trouble than it's worth...
Your choices at this point are:
Each is horrible in its own unique way, but I suspect a lower total file count is the winner here. |
I have a couple Ideas I'm going to toy around with, and each idea is worse than the other :) |
2f252eb
to
0234dea
Compare
0234dea
to
c41f8e9
Compare
I was able to upload two test packages to test pypi.
This may be incorrect, or can be improved, however, I am going to close this PR, as dev releases seem like too much trouble. I'm going to move the changes over to #129 for further review/punishment. |
Pushes binaries to testpypi on merge.
Fixes: #127