Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: no-commands mode #205

Closed
0xDEC0DE opened this issue May 24, 2024 · 2 comments
Closed

Feature request: no-commands mode #205

0xDEC0DE opened this issue May 24, 2024 · 2 comments

Comments

@0xDEC0DE
Copy link
Contributor

0xDEC0DE commented May 24, 2024

Story time!

We have devised a workflow for vendoring in changes that goes something like:

  • Pull in files from upstream
  • Run git apply over the top of them to localize for our needs
  • Fail if the patch does not apply cleanly

When absorbing new versions from upstream, we do a three-way merge of "old upstream", "new upstream", and our localizations. To do this with Gilt, it is necessary to temporarily comment out the post-commands from our Giltfile.yaml to get a "pristine" copy.

Gilt could help with this by providing a command-line switch that only runs the file overlay steps and avoids running post-commands.

TL;DR: we'd like a --no-commands switch, or something similar.

@retr0h
Copy link
Owner

retr0h commented May 24, 2024

Sounds like a reasonable suggestion.

0xDEC0DE pushed a commit to 0xDEC0DE/gilt that referenced this issue May 24, 2024
0xDEC0DE pushed a commit to 0xDEC0DE/gilt that referenced this issue May 24, 2024
0xDEC0DE pushed a commit to 0xDEC0DE/gilt that referenced this issue May 26, 2024
retr0h pushed a commit that referenced this issue May 26, 2024
@retr0h
Copy link
Owner

retr0h commented May 29, 2024

Implemented in #207 ❤️ @0xDEC0DE

@retr0h retr0h closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants