Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building with Go 1.22.2 drops coverage by ~25% #179

Closed
0xDEC0DE opened this issue Apr 29, 2024 · 0 comments · Fixed by #182
Closed

Building with Go 1.22.2 drops coverage by ~25% #179

0xDEC0DE opened this issue Apr 29, 2024 · 0 comments · Fixed by #182

Comments

@0xDEC0DE
Copy link
Contributor

Steps to reproduce

  1. Install Go 1.22.2
  2. Run task test

Expected result

Tests pass, 100% coverage

Actual behavior

Tests pass, 73.5% coverage

Miscellany

task deps should probably look to installing @latest of all dependent packages, rather than locking in at what appears to be arbitrary versions.
retr0h added a commit that referenced this issue May 2, 2024
@retr0h
Switch to go 1.22
dab9e53 
* Switched to go 1.22 and execute coverage with nocoverageredesign
  which seems to correct some buggy coverage reporting
* Also pinned deps to @latest from arbitrary versions
* Updated deprecated golangci config `run.skip-dirs`

Fixes: #179
retr0h added a commit that referenced this issue May 2, 2024
@retr0h
Switch to go 1.22
63e3bc9 
* Switched to go 1.22 and execute coverage with nocoverageredesign
  which seems to correct some buggy coverage reporting
* Also pinned deps to @latest from arbitrary versions
* Updated deprecated golangci config `run.skip-dirs`
* go mod tidy

Fixes: #179
@retr0h retr0h mentioned this issue May 2, 2024
Merged
retr0h added a commit that referenced this issue May 2, 2024
@retr0h
fix: switch to go 1.22
02a62f5 
* Switched to go 1.22 and execute coverage with nocoverageredesign
  which seems to correct some buggy coverage reporting
* Also pinned deps to @latest from arbitrary versions
* Updated deprecated golangci config `run.skip-dirs`
* go mod tidy

Fixes: #179
retr0h added a commit that referenced this issue May 2, 2024
@retr0h
fix: switch to go 1.22
ce55525 
* Switched to go 1.22 and execute coverage with nocoverageredesign
  which seems to correct some buggy coverage reporting
* Also pinned deps to @latest from arbitrary versions
* Updated deprecated golangci config `run.skip-dirs`
* go mod tidy

Fixes: #179
retr0h added a commit that referenced this issue May 2, 2024
@retr0h
fix: switch to go 1.22
b606094 
* Switched to go 1.22 and execute coverage with nocoverageredesign
  which seems to correct some buggy coverage reporting
* Also pinned deps to @latest from arbitrary versions
* Updated deprecated golangci config `run.skip-dirs`
* go mod tidy

Fixes: #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to go 1.22 retr0h/gilt
1 participant
@0xDEC0DE