chore: migrate to gha #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @chiroptical if you have some time, would you mind taking a look at this PR? I have tried to port the travis stuff with minimal effort and split off some more work into a new ticket (see description). |
rethab
commented
Mar 29, 2022
| @@ -25,7 +25,7 @@ tests = [ testCase "get_alice_pub_from_alice" get_alice_pub_from_alice | |||
| , testCase "get_inexistent_from_alice" get_inexistent_pub_from_alice | |||
| , testCase "check_alice_pub_user_ids" check_alice_pub_user_ids | |||
| , testCase "check_alice_pub_subkeys" check_alice_pub_subkeys | |||
| , testCase "remove_alice_key_prompt" remove_alice_key | |||
There was a problem hiding this comment.
is this cheating? This kept failing on CI, but perhaps this could be made working? I'd have to dig a bit more into this..
|
Yeah, is there a way to prevent these pop-ups in the tests? Generally it all looks fine to me. I like that if the "no_ci" tests can be fixed they are just automatically removed from the blacklist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just the bare minimum to get us back to a green tick for PRs and the main branch.
I put the other things I want to do with GHA into a new ticket: #56