[Bifrost] Sequencer gives priority to GetSequencerState requests #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2025
Test Results 7 files ±0 7 suites ±0 3m 29s ⏱️ - 1m 7s Results for commit 9345693. ± Comparison against base commit 765636b. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
tillrohrmann
approved these changes
Feb 7, 2025
This enables nodes to maintain concurrent connections across different actual TCP connections to increase message processing concurrency. This is controlled by a new configuration option in `[networking]` section. This also tags a few operations with `tokio::task::unconstrained` to reduce unnecessary coop-driven yields that happen at some hot-paths. ``` // intentionally empty ```
Introducing histograms and per-message counters. Histograms for processing duration per message are only enabled in debug builds but this decision can change if we found the need to use them for release build ``` // intentionally empty ```
Debug assertions are not meant to be used in release builds, most crates use `cfg(debug_assertions)` as a proxy to detect whether they are built in debug mode or not, this include `tracing` among many others. The side effect of having debug_assertions enabled is (a) performance penalty and (b) TRACE level being enabled in release build because `tracing` can't respect the release max logging filter feature flag if it doesn't know we are building in release mode. ``` // intentionally empty ```
Among other small bits and bobs ``` intentionally empty ```
Those requests are really important to be handled quickly, we are doing two changes in this PR: - Making expensive to run GetSequencerState operations not block the network loop - Give priority to handling those request vs appends ``` // intentionally empty ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those requests are really important to be handled quickly, we are doing two changes in this PR:
Stack created with Sapling. Best reviewed with ReviewStack.