Component and dataset upgrades #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajmz
approved these changes
Jun 13, 2024
AlvaroEzq
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new methods
RangeandApplyRangetoTRestDataSetthey allow to define a sample subset range from the dataset. When we useApplyRangethe internal data frame will be updated too. If we only invokeRangeaRDF::Nodewith the specified range will be returned, but no internal modification will happen.Solving an issue in
ExtractParametricNodesappearing when the dataset is too large, of the order of 1500M entries. The,fSplitEntries=600,000divides the operation of node extraction into several steps. See also ROOT-forum entry: https://root-forum.cern.ch/t/problem-with-large-number-of-entries-inside-rdataframe/59632TRestComponentDataSet::fDFRangedata member added. It allows to control the range of the dataset entries that will be used to generate the component.In a component we can re-scale the distribution using
weights, for the moment the weights were a column from the dataFrame, but now it is allowed also to write down a constant.In this example, the distribution will be built with 2*Ngamma, where Ngamma is the rate contribution from each event.