GSL Integration implementation, TRestAxionMagneticField ReMap feature and HOT bug fix. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Track(Double_t x) implemented to parameterize the field component along a track
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
jgalan
changed the title
for more information, see https://pre-commit.ci
francandon
reviewed
Feb 12, 2024
francandon
reviewed
Feb 12, 2024
| @@ -94,9 +88,10 @@ void TRestAxionField::Initialize() { | |||
| /// The result will be given for an axion-photon coupling of 10^{-10} GeV^{-1} | |||
| /// | |||
| double TRestAxionField::BL(Double_t Bmag, Double_t Lcoh) { | |||
| Double_t lengthInMeters = Lcoh / 1000.; | |||
| Double_t lengthInMeters = Lcoh * units("m"); | |||
There was a problem hiding this comment.
It's a conversion factor from the standard REST units (mm for length) to meters, that's what I understand
tomasoshea
approved these changes
Feb 12, 2024
francandon
approved these changes
Feb 12, 2024
Co-authored-by: Francisco Rodríguez Candón <franrodricandon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRITICAL fix where the axion mass was given in
keVinside theTRestAxionFieldPropagationProcesswhile it should have been expressed ineV. This was leading to wrong results.TRestAxionMagneticField::ReMapmethod added. This method allows to remap the field to a new grid that it is necessarily coarser than the original.TRestAxionField::GammaTransmissionFieldMapProbabilitymethod added. This method will integrate the axion-field using GSL library integration methods. The advantage is that we define the desired accuracy. This method will return a pair with the probability and the corresponding error.TRestAxionFieldimplements now a pointer tofMagneticFieldthat needs to be initialized usingTRestAxionField::AssignMagneticFieldso that the new methodGammaTransmissionFieldMapProbabilityknows how to evaluate the magnetic field alongx.TRestAxionMagneticField::GetTransversalComponentInParametricTrack(Double_t x)new method implemented that allows to evaluate the field along a parametric track. The track is calculated using the field boundaries by providing the particle position and direction to the magnetic field, using the new methodSetTrack( const TVector3 &position, const TVector3 &direction);.TRestAxionFieldPropagationProcessnow it integrates the probability using the new GSL integration method. The data members in this class have been updated to be able to set-up the integration method.TRestAxionFieldPropagationProcessimplements afReMapdata member that allows the process to re-map the magnetic field to a new grid size.