Skip to content

chore: improve syncAccount readability #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Apr 16, 2025

Description

  • Refactors syncAccount to improve readability

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 9429ee3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:32am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:32am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-basic-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-basic-up-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-nansen-demo ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-vue-solana ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am
vue-wagmi-example ⬜️ Ignored (Inspect) Apr 18, 2025 9:32am

Copy link
Contributor

github-actions bot commented Apr 16, 2025

Warnings
⚠️ File packages/appkit/src/client/appkit-base-client.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 9429ee3

Copy link
Contributor

github-actions bot commented Apr 16, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.69% 25353 / 33943
🔵 Statements 74.69% 25353 / 33943
🔵 Functions 66.22% 2141 / 3233
🔵 Branches 83.15% 4897 / 5889
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client/appkit-base-client.ts 72.5% 87.57% 77.48% 72.5% 187-188, 190-191, 196-197, 275-276, 312-318, 347-366, 374-380, 383-384, 399-407, 410-415, 431-435, 448-463, 488-494, 497-507, 510-522, 525-527, 530-532, 535-537, 540-542, 545-551, 554-557, 573-585, 591-624, 627-637, 690-691, 697, 708-722, 728-735, 748-752, 792-793, 834-838, 844-845, 857, 880-885, 964, 966-982, 1000-1001, 1004, 1015, 1030, 1033, 1042, 1052, 1054-1055, 1058, 1064, 1072, 1075, 1082, 1084, 1088, 1104-1105, 1121-1122, 1127-1128, 1161-1168, 1214-1218, 1247-1250, 1254, 1270-1280, 1302-1313, 1342-1343, 1349-1375, 1531-1532, 1560-1561, 1564-1565, 1580-1583, 1586-1587, 1607-1608, 1611-1612, 1633-1634, 1647, 1655, 1658, 1662, 1667-1686, 1689-1698, 1713-1714, 1757-1760, 1763-1764, 1852-1853, 1856-1859, 1862-1863, 1866-1867, 1870-1871, 1874-1875, 1878-1882, 1891-1900, 1909-1920, 1309, 1669-1690
Generated in workflow #11210 for commit 9429ee3 by the Vitest Coverage Report Action

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boyscout principle: while at it - maybe add some Unit Tests? (not blocking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants