chore: adds dynamic locator and element getters in the modal validator #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
11 Skipped Deployments
|
ganchoradkov
commented
Apr 16, 2025
ganchoradkov
commented
Apr 16, 2025
tomiir
reviewed
Apr 16, 2025
Comment on lines
18
to
42
| async getLocator(selector: string, timeout = 5000, interval = 500): Promise<Locator> { | ||
| const start = Date.now() | ||
| while (Date.now() - start < timeout) { | ||
| const element = this.page.locator(selector) | ||
| if (element) { | ||
| return element | ||
| } | ||
| // eslint-disable-next-line no-await-in-loop | ||
| await this.page.waitForTimeout(interval) // Wait before rechecking | ||
| } | ||
| throw new Error(`Element ${selector} did not become visible within ${timeout}ms`) | ||
| } | ||
|
|
||
| async getByTestId(testId: string | RegExp, timeout = 5000, interval = 500): Promise<Locator> { | ||
| const start = Date.now() | ||
| while (Date.now() - start < timeout) { | ||
| const element = this.page.getByTestId(testId) | ||
| if (element) { | ||
| return element | ||
| } | ||
| // eslint-disable-next-line no-await-in-loop | ||
| await this.page.waitForTimeout(interval) // Wait before rechecking | ||
| } | ||
| throw new Error( | ||
| `Element with data-testid="${testId}" did not become visible within ${timeout}ms` |
There was a problem hiding this comment.
Should we make a utils like getElement or something that has the timing part of these?
There was a problem hiding this comment.
wdym? to move these into the shared/utils?
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tomiir
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
locator&elementgetters that try to get an element from the page every n ms until a timeout is hit rather than onceType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist