-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple bumps & fixes to CI versions (Kubernetes, GH Actions, PHP) #380
base: master
Are you sure you want to change the base?
Conversation
2d461f9
to
d5773a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
============================================
+ Coverage 94.17% 94.68% +0.51%
Complexity 700 700
============================================
Files 70 70
Lines 1837 1788 -49
============================================
- Hits 1730 1693 -37
+ Misses 107 95 -12 ☔ View full report in Codecov by Sentry. |
Added a few more commits to fix minor issues, bring in some of the dependabot changes and add PHP 8.3. Summary:
|
02c021a
to
89a2a13
Compare
@rennokki These tests are coming back clean. Revisiting this, I bumped a few other versions and dependencies. Added PHP 8.3, you may want to drop 8.1 since we had 8.0 dropped during this phase of the lifecycle. |
@rennokki Anything else needed to merge this one? I'm happy to make any other adjustments to get this one in. |
(Noticed a GH action once chose podman and failed/flaked there.)
Noticing the cache isn't hitting when action runs. Remove hardcoded composer cache directory. Remove wildcard .* in Laravel version as part of cache key. Bump actions/cache to 3.3.1 (via @V3).
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Please update the following actions to use Node.js 20: actions/cache@v3, codecov/codecov-action@v3.1.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@rennokki I cleaned this up for easier review squashing like for like PRs that stretched over time. Also, removed the overlap with the deprecated package PR. This has just version bumps in the ci.yml file to current versions of kubernetes, laravel, PHP and GH actions. All checks clean. |
Multiple versions being tested now out of support as well as a few fixes:
Note: 1.25 & 1.26 also works and passes tests, but it would add more versions and there's a couple spots in the project and docs that say "latest 3", so I left that off the back.