Fix the XPath sum function.

renggli · Sep 18, 2023 · 675d773 · 675d773
1 parent 8cc76e5
commit 675d773
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/src/xpath/functions/number.dart b/lib/src/xpath/functions/number.dart
@@ -13,9 +13,9 @@ XPathValue number(XPathContext context, List<XPathExpression> arguments) {
 // number sum(node-set)
 XPathValue sum(XPathContext context, List<XPathExpression> arguments) {
   XPathEvaluationException.checkArgumentCount('sum', arguments, 1);
-  final nodes = arguments[0](context).nodes;
-  return XPathNumber(nodes
-      .map((node) => num.tryParse(node.toXmlString()) ?? 0)
+  return XPathNumber(arguments[0](context)
+      .nodes
+      .map((node) => num.tryParse(XPathNodeSet([node]).string) ?? 0)
       .fold(0, (a, b) => a + b));
 }
 

diff --git a/test/xpath_test.dart b/test/xpath_test.dart
@@ -461,6 +461,8 @@ void main() {
       });
       test('sum', () {
         expectEvaluate(xml, 'sum(//text())', isNumber(6));
+        final attr = XmlDocument.parse('<r><e a="36"/><e a="6"/></r>');
+        expectEvaluate(attr, 'sum(/r/e/@a)', isNumber(42));
       });
       test('floor', () {
         expectEvaluate(xml, 'floor(-1.5)', isNumber(-2));