Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid PLL2 configuration in R_CGC_ClocksCfg FSP5.7.0 #386

Open
andross092 opened this issue Jan 8, 2025 · 3 comments
Open

Invalid PLL2 configuration in R_CGC_ClocksCfg FSP5.7.0 #386

andross092 opened this issue Jan 8, 2025 · 3 comments
Assignees
Labels

Comments

@andross092
Copy link

andross092 commented Jan 8, 2025

Please check line 598 in r_cgc.c

the code

r_cgc_pll_cfg(&p_clock_cfg->pll2_cfg, CGC_CLOCK_PLL2, pll2_hz, pllccr);
uses the variable pllccr filled for PLL configuration.
It should be pll2ccr
Thanks for support

@renesas-austin-hansen
Copy link
Collaborator

Hi @andross092, which version of FSP are you using? I was not able to find this issue in recent versions.

@andross092
Copy link
Author

andross092 commented Jan 8, 2025

I'm using FSP 5.7.0,
anyway it is in the master branch

r_cgc_pll_cfg(&p_clock_cfg->pll2_cfg, CGC_CLOCK_PLL2, pll2_hz, pllccr);

as you can see here
https://github.com/renesas/fsp/blob/21e946ba20a3a25737ad7d8808596a4771d0671a/ra/fsp/src/r_cgc/r_cgc.c#L507C2-L514C6

pll2ccr is redeemed, but then it is not used in the actual r_cgc_pll_cfg for PLL2

@renesas-austin-hansen
Copy link
Collaborator

Ah sorry, line numbers are a bit offset in our development system and I got mixed up with a similar function. We will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants