core: add external key config #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehyunc
force-pushed
the
sehyun/add-external-config
branch
from
7b79d68 to
0d77cf5
Compare
sehyunc
force-pushed
the
sehyun/add-external-config
branch
3 times, most recently
from
4eb14c4 to
d9e55ae
Compare
joeykraut
approved these changes
Dec 24, 2024
| import { type BaseConfig, keyTypes } from './createConfig.js' | ||
| import type * as rustUtils from './utils.d.ts' | ||
|
|
||
| export type CreateBYOKConfigParameters = { |
There was a problem hiding this comment.
not: External rather than byok as discussed
Same below
sehyunc
force-pushed
the
sehyun/add-external-config
branch
from
d9e55ae to
8a9159f
Compare
sehyunc
force-pushed
the
sehyun/add-external-config
branch
from
8a9159f to
f21a89f
Compare
sehyunc
added a commit
that referenced
this pull request
Dec 27, 2024
* core: add external key config (#129) core: add external config, modify BaseConfig * core: add symmetric key getter to config (#130) * core: add symmetric key getter to config * core: ingest changes into websocket * wasm, core: implement keychain rotation for external key (#131) * wasm, core: implement keychain rotation for external key * wasm, core: impl key rotation for withdraw; * wasm, core: impl key rotation for create order * wasm, core: impl key rotation for cancel order * core: format * wasm: cleaner rotation * wasm: abstract key rotation logic into helper * wasm, core: impl external key deposit action (#132) * wasm: add sign callback invocation helper * wasm, core: impl external key deposit action * wasm, core: impl external key withdraw action (#133) * wasm, core: impl external key withdraw action * wasm: simplify signing fns * wasm: organize signing fn * wasm, core: impl external key create order action (#134) * wasm, core: impl external key create order action * wasm, core: impl external key cancel order action (#135) * wasm, core: remove need for key_type in Rust context (#136) * wasm, core: remove need for key_type in Rust context * core: add safety checks to actions * wasm, core: impl external key get pk scalars (#137) * wasm: do not prehash message when using external signer (#138) wasm: remove prehash assumption * chore: lint * core: impl await task completion for externally managed keys (#139) * core: impl get order + pay fees for external keys (#140) core: impl get order + pay fees for externally managed keys * wasm, core, node: impl external wallet key generation script (#141) * node: export GeneratedSecrets type * wasm, core: impl external key create wallet (#142) * wasm, core: impl external key create wallet * wasm, core: impl external key lookup wallet (#144) * wasm, core: impl external key refresh wallet (#143) core: impl refresh wallet for externally managed keys * core: add public key getter and setter fns to external config (#145) core: add public key getter and setter in external config * core: fix create order in matching pool args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the external key config and standardizes config fields to export a
getBaseUrlhelper instead of a config-specific helper e.g.getRelayerBaseUrlorgetAuthServerUrl. This exposes a more predictable interface for all configs. It also adds arenegadeKeyTypefield to configs to specify whether the key is an external managed key or an internally managed key.Testing