wasm, core, react: tidy unnecessary fns, build artifacts #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehyunc
force-pushed
the
sehyun/tidy-wasm-1
branch
2 times, most recently
from
7a57959 to
d1e28cb
Compare
sehyunc
force-pushed
the
sehyun/tidy-wasm-1
branch
from
d1e28cb to
77fcd0f
Compare
akirillo
requested changes
Oct 28, 2024
There was a problem hiding this comment.
I like this, but if we're going to remove WASM build artifacts, we should:
- Remove
Cargo.lockfrom thewasmcrate's.gitignore - Add a
rust-toolchainfile to thewasmcrate specifying an exact Rust compiler version
This gets us (mostly) reproducible WASM builds for a given commit. I say mostly because the WASM build script invokeswasm-pack, so the built artifacts depend on the version ofwasm-packon the build machine, but it's still good to lock down the Rust compilation artifacts.
akirillo
approved these changes
Oct 28, 2024
sehyunc
force-pushed
the
sehyun/tidy-wasm-1
branch
from
0d14627 to
85c5539
Compare
☑️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes old Rust functions that are no longer used. It also removes from git tracking build artifacts of
wasm-pack.Testing
Tested locally on mainnet stack, all functions work as expected.
wasm-packbuild artifacts are included in bundle as seen in NPM registry.