-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗑️ Add delete-app command #24
Merged
renanbastos93
merged 9 commits into
renanbastos93:main
from
davidgaspardev:feature/add-delete-app-command
Oct 25, 2024
Merged
🗑️ Add delete-app command #24
renanbastos93
merged 9 commits into
renanbastos93:main
from
davidgaspardev:feature/add-delete-app-command
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new command "delete-app" to the boneless CLI tool. This command allows users to delete an app that was previously created. The command takes the app name as an argument and deletes the corresponding app folder from the internal directory. If the app folder does not exist, an error message is displayed. Upon successful deletion, a confirmation message is printed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very happy with your contribution. I just made two suggestions. Thank you!
Refactor the delete.go file to handle errors gracefully when deleting an app folder or checking if the app folder exists. Instead of using os.Exit(1), the code now uses panic(err) to propagate the error. This ensures that the program terminates with an error message and stack trace, providing better debugging information. Co-authored-by: renanbastos93 <renanbastos.tec@gmail.com>
Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com>
Co-authored-by: Renan Bastos <renanbastos.tec@gmail.com>
renanbastos93
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new command
delete-app
to theboneless
CLI tool, allowing users to delete an existing app. The command ensures that critical components likeapp
andbff
cannot be deleted.Changes
Command Addition in
main.go
:delete-app
to the list of available commands.delete-app
command.delete-app
command logic in themain
function.New File
delete.go
:delete.go
in theinternal
package.DeleteApp
] function to handle the deletion of app folders.validateAppName
]: Ensures critical components cannot be deleted.checkIfAppFolderExists
]: Checks if the app folder exists before attempting deletion.getAppFolderPath
]: Constructs the path to the app folder based on the app name.Usage
boneless delete-app <app-name>
boneless delete-app my-app
This command will delete the specified app folder if it exists and is not a critical component.
Testing
delete-app
command correctly deletes existing app folders.app
] or [bff
] results in an appropriate error message and no deletion occurs.Notes
boneless
] CLI by providing a straightforward way to remove apps that are no longer needed.