Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cancellation of the local mob timer when doing mob done or mob next #406

Closed
hollesse opened this issue Jan 25, 2024 · 2 comments · Fixed by #407
Closed

Remove cancellation of the local mob timer when doing mob done or mob next #406

hollesse opened this issue Jan 25, 2024 · 2 comments · Fixed by #407

Comments

@hollesse
Copy link
Member

hollesse commented Jan 25, 2024

We should remove this feature for the following reasons:

  • If you switch from one codebase to another the timer gets stopped and a new timer will start. This could lead to longer rotation times
  • the way we stop the timer is just searching for the right process and killing it. This is a behavior which is suspicious for the most virus detection applications and could be one cause why mob is listed for some virus detection tools in windows. (see Virusdetection on mob.exe #357)
@hollesse hollesse changed the title Remove abortion of the local mob timer when doing mob done or mob next Remove cancellation of the local mob timer when doing mob done or mob next Jan 25, 2024
@gregorriegler
Copy link
Collaborator

@hollesse
Copy link
Member Author

hollesse commented Feb 4, 2024

@gregorriegler I knew. I tested it before on virustotal. But if you have a look at the behavior analysis then it looks at least a bit better. I think this is a problem which has emerged and therefore we need to look at different points where we need to adjust. And this is just one point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants