Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafety: Fix vite-node resolution in TS plugin #12039

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Sep 26, 2024

Note, this is a PR to #12019.

Within the context of the TS plugin running within my editor, the root directory of the vite-node server was "/" rather than the project directory.

It looks like this is because it was defaulting to the current working directory, which is different in a TS plugin context compared to regular Vite / CLI usage. If I log process.cwd() within the TS plugin, I get "/".

The fix was to explicitly pass our resolved root directory to vite-node rather than relying on cwd by default.

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 72a20c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori merged commit 722db5c into pedro/typesafety-phase-1 Sep 26, 2024
8 checks passed
@pcattori pcattori deleted the markdalgleish/fix-ts-plugin-vite-node-resolution branch September 26, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants