Route chunks: Add modules preloads #11954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markdalgleish
commented
Sep 4, 2024
| // The `<Script>` will render rel=modulepreload for the current page, we don't | ||
| // need to include them in a page prefetch, this gives us the list to remove | ||
| // while deduping. | ||
| function getCurrentPageModulePreloadHrefs( |
There was a problem hiding this comment.
Apart from the manifest arg having a different name, this function was identical to getModuleLinkHrefs above. I went with manifest rather than manifestPatch as the canonical arg name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to add this was more difficult than expected due to some duplication in the code, so I fixed that while I was here. There's now a single source of truth for calculating the preload links.