Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route chunks: Improve chunk generation performance #11953

Conversation

markdalgleish
Copy link
Member

Since caching was based on IDs which also included route chunk query strings (e.g. ?route-chunk=clientLoader) there was a lot of wasted work that couldn't be cached across route chunks. This refactor ensures that only the desired route chunk is generated based on the query string value.

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: b6d19f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish changed the title Improve route chunk load performance Route chunks: Improve route chunk load performance Sep 4, 2024
@markdalgleish markdalgleish changed the title Route chunks: Improve route chunk load performance Route chunks: Improve chunk generation performance Sep 4, 2024
@markdalgleish markdalgleish merged commit 359318e into markdalgleish/route-chunks Sep 4, 2024
7 of 8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/split-get-route-chunks branch September 4, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant