ssr field will be omitted and scan will be true when vite does its
#11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client dep optimization pass for local dev in that case, the module graph is treated like a client-module graph without any transforms, so we need to disable the `.server` detection during deps discovery in the future, it would be better to have separate module graphs for client and server without requiring transforms so that this all works with Vite out-of-the-box and server dependencies are not optimized for use by the client
|
pcattori
deleted the
pedro/disable-dot-server-detection-for-optimize-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client dep optimization pass for local dev
in that case, the module graph is treated like a client-module graph without any transforms, so we need to disable the
.serverdetection during deps discoveryin the future, it would be better to have separate module graphs for client and server without requiring transforms so that this all works with Vite out-of-the-box and server dependencies are not optimized for use by the client
See remix-run/remix#9921