Fix Playwright hanging in Node 20.5.2+ #11446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #11440 and remix-run/remix#9000 (in this repo).
Since moving to pnpm, we've had issues with Playwright tests hanging in Node 20.5.2+. I was able to narrow it down to workspace package imports being the cause. With pnpm, our built code no longer resides in a
node_modules
directory but is linked to thepackages
directory instead which means that Playwright no longer treats it as external. If we mark the packages dir as external, the tests don't hang anymore.