Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playwright hanging in Node 20.5.2+ #11446

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Apr 15, 2024

This reverts #11440 and remix-run/remix#9000 (in this repo).

Since moving to pnpm, we've had issues with Playwright tests hanging in Node 20.5.2+. I was able to narrow it down to workspace package imports being the cause. With pnpm, our built code no longer resides in a node_modules directory but is linked to the packages directory instead which means that Playwright no longer treats it as external. If we mark the packages dir as external, the tests don't hang anymore.

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 9e89ef2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 6003e32 into v7 Apr 15, 2024
3 of 5 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-playwright-hanging branch April 15, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant