Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript to ^5.4.5 #11445

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Upgrade TypeScript to ^5.4.5 #11445

merged 2 commits into from
Apr 16, 2024

Conversation

markdalgleish
Copy link
Member

I've noticed the Rollup build intermittently hangs locally. When diagnosing with why-is-node-running it seemed to be coming from a TypeScript file watcher. Upgrading to the latest version of TypeScript resolves the issue for me.

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 0593ed3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

great find - I pulled latest v7 and it hung on the first try. Pulled this branch and ran 10 builds without it hanging so looks ✅ from my end

@brophdawg11 brophdawg11 merged commit b072725 into v7 Apr 16, 2024
6 of 8 checks passed
@brophdawg11 brophdawg11 deleted the markdalgleish/upgrade-typescript branch April 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants