Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashRouter hashType option. Compatibility with v4/v5 #11310

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Whaileee
Copy link

During migration from v4/v5 to v6 I've found that hashType is not implemented in newer version. This is an issue since there is a whole instruction on migration. I cannot change the type of encoding in project that this is applicable to.
I've raised an issue quite some time ago, but misspelled the prop name, hence the issue was closed.
Looking forward to resolve any of my errors and I'd love to see this merged/released asap.
Thanks in advance

Issue
v5 related docs

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 27, 2024

Hi @Whaileee,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: 07f2a3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-config-routes-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 27, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@Whaileee
Copy link
Author

@brophdawg11
Can I get some feedback about the pr?
BR
Konrad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant