-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HashRouter hashType option. Compatibility with v4/v5 #11310
base: dev
Are you sure you want to change the base?
Conversation
Hi @Whaileee, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
🦋 Changeset detectedLatest commit: 07f2a3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
df6caa6
to
8824908
Compare
1994c9a
to
8457a4d
Compare
92e46c0
to
f1a9dd4
Compare
2ea44cc
to
3d0c1b3
Compare
@brophdawg11 |
During migration from v4/v5 to v6 I've found that hashType is not implemented in newer version. This is an issue since there is a whole instruction on migration. I cannot change the type of encoding in project that this is applicable to.
I've raised an issue quite some time ago, but misspelled the prop name, hence the issue was closed.
Looking forward to resolve any of my errors and I'd love to see this merged/released asap.
Thanks in advance
Issue
v5 related docs