Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (a11y)-Multiple accessibility issues with React-Router #11915

Closed
akash07k opened this issue Aug 21, 2024 · 1 comment
Closed

[Bug]: (a11y)-Multiple accessibility issues with React-Router #11915

akash07k opened this issue Aug 21, 2024 · 1 comment
Labels

Comments

@akash07k
Copy link

What version of React Router are you using?

6.26.1

Steps to Reproduce

  1. Implement React-router in any app.
  2. Define couple of the routes
  3. Run the app
  4. Click on any of the link and observe the screen reader announcement and focus

Expected Behavior

Screen reader should announce tht title of the newly loaded page

Actual Behavior

Whenever we click on any route (<link>), the page title of the newly loaded page is not announced.
Also, the focus is set to somewhere randomly on the page.

@akash07k akash07k added the bug label Aug 21, 2024
@timdorr
Copy link
Member

timdorr commented Aug 21, 2024

The page title is up to you, as there are different ways of defining that and triggering the update. Focus is also dependant on how you've set up your page and isn't something the library can infer as easily. I would recommend a layout route to centralize these things: https://reactrouter.com/en/main/start/concepts#layout-routes

@timdorr timdorr closed this as completed Aug 21, 2024
@remix-run remix-run deleted a comment from akash07k Aug 21, 2024
@remix-run remix-run locked as too heated and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants