Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Integration #111

Open
codeshrew opened this issue May 17, 2012 · 8 comments
Open

Github Integration #111

codeshrew opened this issue May 17, 2012 · 8 comments
Labels
Milestone

Comments

@codeshrew
Copy link

API token is still used in preferences. Needs to be updated to newest API.

Quote from Github help:

Previous versions of our API used token authentication, but we’re removing support for that soon, see our GitHub API Moving On blog post for details.

If you are using a 3rd party tool that is asking for your token, you should contact the maintainer and ask them to update to our latest API as the old API will stop working soon.

@mariusbutuc
Copy link

bump...

After a fresh install of JewelryBox, v1.2.1, it took me a bit to look for the github API token. :)

@docwhat
Copy link

docwhat commented Aug 13, 2012

Isn't this a bug, not a feature? Since the old API is now gone?

@remear
Copy link
Owner

remear commented Aug 13, 2012

Last I knew desktop OAuth for Github was disabled. I'm still not sure how users would react to being required to use basic authentication for Github services in JewelryBox.

@docwhat
Copy link

docwhat commented Aug 13, 2012

According to https://gist.github.com/419219 it looks like the desktop OAuth is disabled. :-(

The non-desktop version is here: http://developer.github.com/v3/oauth/

I suppose you could automate the "creating an OAuth token for command line use" as shown here: https://help.github.com/articles/creating-an-oauth-token-for-command-line-use

This would let you set the "note" so that it shows up as "Jewelry Box on " so they know what it is.

Ciao!

@remear
Copy link
Owner

remear commented Aug 27, 2012

Since token-based usage of the Github API no longer exists, the best way to update this feature and extend it is to store the user's Github username and password in the Keychain so it remains secure. That will allow JewelryBox to retrieve it for basic auth calls to the API.

Objections?

@remear
Copy link
Owner

remear commented Aug 27, 2012

Keep in mind that this might cause multiple prompts for the user's password to access the Keychain.I'm not sure yet exactly how many or the frequency in which they would occur.

@mariusbutuc
Copy link

@remear any news on the number or the frequency in which the Keychain prompts would occur?

@remear
Copy link
Owner

remear commented Sep 6, 2012

@mariusbutuc Ideally I'd like it to work like the prompts you usually see where the options are "Always Allow", "Allow", or "Deny". I also haven't decided on the best way to initially prompt the user to store their github password in the keychain. I haven't had time to look into this yet since I'm trying to wrap up v1.4 and this is tentatively scheduled for v1.5. I'll post more info here as I continue to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants