-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Integration #111
Comments
bump... After a fresh install of JewelryBox, v1.2.1, it took me a bit to look for the github API token. :) |
Isn't this a bug, not a feature? Since the old API is now gone? |
Last I knew desktop OAuth for Github was disabled. I'm still not sure how users would react to being required to use basic authentication for Github services in JewelryBox. |
According to https://gist.github.com/419219 it looks like the desktop OAuth is disabled. :-( The non-desktop version is here: http://developer.github.com/v3/oauth/ I suppose you could automate the "creating an OAuth token for command line use" as shown here: https://help.github.com/articles/creating-an-oauth-token-for-command-line-use This would let you set the "note" so that it shows up as "Jewelry Box on " so they know what it is. Ciao! |
Since token-based usage of the Github API no longer exists, the best way to update this feature and extend it is to store the user's Github username and password in the Keychain so it remains secure. That will allow JewelryBox to retrieve it for basic auth calls to the API. Objections? |
Keep in mind that this might cause multiple prompts for the user's password to access the Keychain.I'm not sure yet exactly how many or the frequency in which they would occur. |
@remear any news on the number or the frequency in which the Keychain prompts would occur? |
@mariusbutuc Ideally I'd like it to work like the prompts you usually see where the options are "Always Allow", "Allow", or "Deny". I also haven't decided on the best way to initially prompt the user to store their github password in the keychain. I haven't had time to look into this yet since I'm trying to wrap up v1.4 and this is tentatively scheduled for v1.5. I'll post more info here as I continue to work on it. |
API token is still used in preferences. Needs to be updated to newest API.
Quote from Github help:
The text was updated successfully, but these errors were encountered: