Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence schematron-related SXWN9000 Saxon error #241

Closed
wants to merge 1 commit into from
Closed

Silence schematron-related SXWN9000 Saxon error #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...hematron/src/main/com/thaiopensource/validate/schematron/NewSaxonSchemaReaderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ public void initTransformerFactory(TransformerFactory factory) {
}
factory.setAttribute(FeatureKeys.LINE_NUMBERING, Boolean.TRUE);
factory.setAttribute(FeatureKeys.VERSION_WARNING, Boolean.FALSE);
factory.setErrorListener(new SilencingErrorListener());
}
}
20 changes: 20 additions & 0 deletions mod/schematron/src/main/com/thaiopensource/validate/schematron/SilencingErrorListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package com.thaiopensource.validate.schematron;

import net.sf.saxon.lib.StandardErrorListener;
import net.sf.saxon.trans.XPathException;

import javax.xml.transform.TransformerException;

public class SilencingErrorListener extends StandardErrorListener {
@Override
public void warning(TransformerException exception)
throws TransformerException {
if (exception instanceof XPathException) {
XPathException xe = (XPathException) exception;
if ("SXWN9000".equals(xe.getErrorCodeLocalPart())) {
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially silence other warnings (the error code is not specific to this particular issue).… but since these are static errors and the XSLT is statically known and under Jing’s control, I think it’s OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially silence other warnings (the error code is not specific to this particular issue).…

Right, but if we wanted to isolate just the “The parent axis starting at a document node will never select anything” case, then as far as I can see the only alternative would be to do string-matching against the message text — which would only work when the messages are emitted in English, but not for other locales. Right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is my understanding as well.
I made that comment for the sake of clarity, but again I think silencing all SXWN9000 is safe.

}
}
super.warning(exception);
}
}