Silence schematron-related SXWN9000 Saxon error #241
Conversation
sideshowbarker
force-pushed
the
SilencingErrorListener
branch
from
f3350d7 to
185c071
Compare
| if (exception instanceof XPathException) { | ||
| XPathException xe = (XPathException) exception; | ||
| if ("SXWN9000".equals(xe.getErrorCodeLocalPart())) { | ||
| return; |
There was a problem hiding this comment.
This could potentially silence other warnings (the error code is not specific to this particular issue).… but since these are static errors and the XSLT is statically known and under Jing’s control, I think it’s OK.
There was a problem hiding this comment.
This could potentially silence other warnings (the error code is not specific to this particular issue).…
Right, but if we wanted to isolate just the “The parent axis starting at a document node will never select anything” case, then as far as I can see the only alternative would be to do string-matching against the message text — which would only work when the messages are emitted in English, but not for other locales. Right?
There was a problem hiding this comment.
Yes, this is my understanding as well.
I made that comment for the sake of clarity, but again I think silencing all SXWN9000 is safe.
|
I guess this is fine. I hope a fix at the XSLT level is also available sometime. Any tools that invoke Jing with their own error handler will probably have to replicate this approach. |
Per #240 (comment) it seems there actually is. So I’ll go ahead and close this PR in favor of #244 (which does what @georgebina suggests in that comment).
Yeah, I hadn’t thought of that. That makes it a pretty suboptimal fix, so it would be great if we can agreement that the patch in #244 will work |
Fixes #240