new: insert file or tcp socket to api.Module #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add required exported interface to insert files or TCP sockets to an `api.Module`.
Revert a previously merged-without-testing PR which could have broken a few tests and causing deadlocks.
erikziyunchi
approved these changes
Dec 10, 2023
gaukas
added a commit
that referenced
this pull request
Dec 17, 2023
* new: insert file or tcp socket to api.Module Add required exported interface to insert files or TCP sockets to an `api.Module`. * fix: newTcpConn not implemented * revert: add sync.RWMutex to Table Revert a previously merged-without-testing PR which could have broken a few tests and causing deadlocks. * fix: skip pre-commit check * fix: remove residual comment [ci skip] * new: test pushfd * fix: race in goroutine * fix: skip pushing TCP conn * fix: remove redundancy
gaukas
added a commit
that referenced
this pull request
Dec 27, 2023
* new: insert file or tcp socket to api.Module Add required exported interface to insert files or TCP sockets to an `api.Module`. * fix: newTcpConn not implemented * revert: add sync.RWMutex to Table Revert a previously merged-without-testing PR which could have broken a few tests and causing deadlocks. * fix: skip pre-commit check * fix: remove residual comment [ci skip] * new: test pushfd * fix: race in goroutine * fix: skip pushing TCP conn * fix: remove redundancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add required (exported) interface to insert files or TCP sockets to an
api.Module.Close #2.