-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Mantine): support mantine 7 #6345
Open
alodela
wants to merge
70
commits into
refinedev:main
Choose a base branch
from
alodela:mantine7.v4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
13cbd1f
feat(mantine): mantine 7
glebtv 51f4503
feat(inferencer): mantine 7
glebtv 8cdbcb8
feat(ui-tests): mantine 7
glebtv 41febc0
feat(live-previews): mantine 7
glebtv e06b1dd
feat(examples): mantine 7
glebtv f7b8900
fix(mantine): mantine select crashes when label is undefined
glebtv 9aaa2d9
Merge branch 'master' into mantine7.v4
BatuhanW 29349da
fix(mantine): fix e2e tests
glebtv fcee89d
chore: format files
BatuhanW c85e590
Merge branch 'master' into mantine7.v4
BatuhanW c67ad52
fix(mantine): restore accidentally removed class
glebtv 9aba874
fix(inferencer): update test snapshots
glebtv 7f16ddb
chore(mantine): remove unused types, remove ThemedLayout v1, remove c…
glebtv e152887
chore(mantine): add changeset, undo changes to package versions
glebtv e5e65a5
fix(mantine): better action button variant handling
glebtv 00b4538
fix(mantine): move github banner to appshell footer
glebtv 082517b
fix: restore refinedev/mantine version
glebtv cde6385
fix: examples/base-mantine remove unused filter
glebtv d2c8563
fix: remove commented code, better mantine test wrapper
glebtv 451ad37
Merge branch 'master' into mantine7.v4
glebtv 230c0a6
Merge branch 'master' into mantine7.v4
BatuhanW 2a05017
fix(inferencer): add React import to mantine inferencer generated code
glebtv 3221708
Merge branch 'master' into mantine7.v4
BatuhanW 6afde2f
Merge branch 'master' into mantine7.v4
BatuhanW 04e0f4b
chore(mantine): split changesets as per review
glebtv 2d89b2f
chore(mantine): remove commented code
glebtv f7d75f7
chore(mantine): icon color should be primary
glebtv 34480b7
fix(inferencer): filterDataOnExactSearchMatch is no longer available …
glebtv 9260b67
Merge branch 'master' into mantine7.v4
BatuhanW 1817134
Merge remote-tracking branch 'upstream/master' into mantine7-v2-1
glebtv f20d327
fix(mantine): try fix biome lint error
glebtv e0e99af
chore(mantine): update mantine version in docs
glebtv bacc65a
Merge remote-tracking branch 'upstream/releases/april' into mantine7.v4
glebtv 77f7e9c
chore: try fix biome errors
glebtv 515dc57
chore: fix versions after merge, fix mantine delete button tests
glebtv 494fb07
Merge branch 'master' into mantine7.v4
alodela 7fc8ffe
feat(mantine): mantine 7
alodela cdebb7e
chore(mantine): update packages version
alodela 04b6720
Merge branch 'refinedev:master' into mantine7.v4
alodela ced22ca
Merge branch 'master' into mantine7.v4
alodela e460d33
fix(mantine): lint & build errors
alodela 01c08f1
fix(mantine): update form types in examples
alodela 6518830
Merge branch 'master' into mantine7.v4
alodela e8b46f4
Merge branch 'master' into mantine7.v4
BatuhanW 3bd2870
Merge branch 'master' into mantine7.v4
alodela 60e515a
Merge branch 'master' into mantine7.v4
alodela c2972c6
Merge branch 'master' into mantine7.v4
BatuhanW 00be382
Merge branch 'master' into mantine7.v4
alodela 0104168
Merge branch 'master' into mantine7.v4
alodela ba364b7
Merge branch 'master' into mantine7.v4
alodela 65c68d4
Merge branch 'master' into mantine7.v4
alodela a688bd3
fix(mantine): fix action icon style
alodela 10b36cf
Merge branch 'master' into mantine7.v4
alodela 6e9c66a
Merge branch 'master' into mantine7.v4
alodela faf028d
Merge branch 'master' into mantine7.v4
alodela ceaf214
Merge branch 'master' into mantine7.v4
alodela a5365d2
fix(mantine): update snapshots
alodela a6eccbb
Merge branch 'master' into mantine7.v4
alodela 935ce43
Merge branch 'main' into mantine7.v4
alodela 58cf201
Merge branch 'main' into mantine7.v4
alodela 2a9d078
Merge branch 'main' into mantine7.v4
alodela 689f08c
Merge branch 'main' into mantine7.v4
alodela a53f76c
chore(mantine): update documentation
alodela e0de4e4
Merge branch 'main' into mantine7.v4
alodela e524a95
Merge branch 'main' into mantine7.v4
alodela 3edd2d4
Merge branch 'main' into mantine7.v4
alodela 1ee0029
Merge branch 'main' into mantine7.v4
alodela 36fdc2b
Merge branch 'main' into mantine7.v4
alodela 01332a4
Merge branch 'main' into mantine7.v4
alodela b493970
Merge branch 'main' into mantine7.v4
alodela File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(mantine): fix action icon style
- Loading branch information
commit a688bd344f0a37f5d05b1bf930a1a977fe0d1d5f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding the
variant="subtle"
attribute to all theActionIcon
components that are used for the back buttons in the crud components.This is the style of the action icon in v5:

With the v7 upgrade it looks like a primary button:

With

varlian="subtle"
it looks similar to the v5 version:Works also with dark mode (see https://mantine.dev/core/action-icon/#usage).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kruschid Great suggestion. I've updated all the back buttons.