Fixed input padding and voice channel chat layout #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there isn't any padding that moves the input box for me? |
|
yeah im kinda confused as to where this padding is coming from, i agree with the background thing tho |
Oh, just realized its actually caused by Desktop Refresh Fast Follows: Larger Guild Icons experiment, my bad |
|
you probably shouldn't remove the padding either, it is there to make the spacing consistent due to the resizeHandle. |
|
i'll just fix myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input field was moved a bit to the right because of padding-left and padding-right and it looked wrong.
Voice chat layout on lower aspect ratio was looking weird because it turned into floating and it looked weird because all 3 parts were separate.
I removed padding from input, removed vc chat left padding and gave it background so it looks more integrated.
Before:
https://domitori.xyz/X7Swt.png
After:
https://domitori.xyz/x0Fp1.png
Couldnt upload images for some reason, sorry for links