Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using vswhere to find Visual Studio installation #41

Open
xforce opened this issue Apr 25, 2019 · 1 comment
Open

Consider using vswhere to find Visual Studio installation #41

xforce opened this issue Apr 25, 2019 · 1 comment

Comments

@xforce
Copy link

xforce commented Apr 25, 2019

Right now the code in MSVSVersion.py uses the registry to find the Visual Studio installation.
I re-installed my windows 10 recently and only installed the latest copy of Visual Studio 2019, as it turns out none of the registry keys being checked exist on my machine.

I suggest checking for the default location of vswhere.exe and downloading it if it's not there, so we use that to find the Visual Studio installation.

Is this something that makes sense here, I would be happy to implement this and submit a PR.

@refack
Copy link
Owner

refack commented Apr 25, 2019

Great minds...
I already have a patch in the works
https://github.com/refack/GYP/blob/c9aad58fb672f5e40847c5740e26f879da8373a0/gyp/common.py#L742-L759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants