-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes and features #535
Open
PurelyAndy
wants to merge
13
commits into
redscientistlabs:51X
Choose a base branch
from
PurelyAndy:51X
base: 51X
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfixes: 37 ("Send to My VMDs" errors if VMD name contains special characters (e.g. "?") and especially "/" or "\" which it interprets as part of the filepath instead of filename) 38 (Null object reference on killswitch if crash sound set to "none") 36 (If the Savestate manager is empty, trying to delete the "1" slot will cause an error. if it has more then one state in it trying to delete the first empty slot causes the same error as well.) The stockpile manager now has an option to load entries when the arrows are pressed to select items. Disabled by default to match previous bugged behavior. BlastEditorForm.RemoveSelected now properly removes from both BindingSources. Don't know what bugged behavior this caused previously, if it even did cause any, but the code was wrong. FullSpec.UnregisterUpdateAction & RegisterUpdateAction were broken, obsolete, and entirely unused, so they have been removed. The stockpile manager's save button will now properly return to the original color upon saving, even if the user changes the color scheme. If the stockpile manager's save button is red, it will not be reset to the default color upon changing RTC's color scheme. Features: 13 (Add load and save to rightclick menu of savestate manager.) 5 (Option to disable Alignment in order to gain easy compat with variable instruction length) 9 (Savestate Manager: Have the 'Save' button light up when changes have been made, like the stockpile manager) Add an option to not compress SSKs Option to enable/disable loading stash entries when the arrows are pressed. Enabled by default to match previous behavior. Turn the stockpile manager's Save As button red when there are unsaved changes if the save button is disabled Other: Removed some useless code in Logging.cs. Added `CLUSTER_` IDs to RTCSPEC rather than hardcoding them as strings throughout.
Reload the last custom layout (or both if one was open and loaded to an external window) When an external layout's window is closed or a different one is loaded, reload the main form's grid to ensure any missing controls are put back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
36 (If the Savestate manager is empty, trying to delete the "1" slot will cause an error. if it has more then one state in it trying to delete the first empty slot causes the same error as well.)
37 ("Send to My VMDs" errors if VMD name contains special characters (e.g. "?") and especially "/" or "" which it interprets as part of the filepath instead of filename)
38 (Null object reference on killswitch if crash sound set to "none")
The stockpile manager now has an option to load entries when the arrows are pressed to select items. Disabled by default to match previous bugged behavior.
BlastEditorForm.RemoveSelected now properly removes from both BindingSources. Don't know what bugged behavior this caused previously, if it even did cause any, but the code was wrong.
FullSpec.UnregisterUpdateAction & RegisterUpdateAction were broken, obsolete, and entirely unused, so they have been removed.
The stockpile manager's save button will now properly return to the original color upon saving, even if the user changes the color scheme.
If the stockpile manager's save button is red, it will not be reset to the default color upon changing RTC's color scheme.
Importing save states no longer creates bugged keyless states
Features:
5 (Option to disable Alignment in order to gain easy compat with variable instruction length)
8 (Tickbox for Cluster + Vector for infinite lifetime units) [Actually removed hellgenie engine and moved the freeze settings to the general parameters]
9 (Savestate Manager: Have the 'Save' button light up when changes have been made, like the stockpile manager)
13 (Add load and save to rightclick menu of savestate manager.)
45 ("Reload custom layout?" yes/no box when restarting after a crash) [Actually made custom layouts reload automatically]
51 (Prevent duplicate units being created on the same address from a large blast on a small domain. It makes sanitizing twice as difficult.)
Add an option to not compress SSKs
Option to enable/disable loading stash entries when the arrows are pressed. Enabled by default to match previous behavior.
Turn the stockpile manager's Save As button red when there are unsaved changes if the save button is disabled
Most component forms and grids are now resizable.
Docked forms can now be popped out by clicking and dragging on their headers.
Custom layouts may now specify a minimum size for resizing.
Other:
Removed some useless code in Logging.cs.
Added
CLUSTER_
IDs to RTCSPEC rather than hardcoding them as strings throughout.Small alignment tweaks have been made throughout the GUI.