Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return keys on load #93

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Return keys on load #93

merged 3 commits into from
Jan 11, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

Returns the list of keys written to redis on load/write. This is required by both llamaindex and langchain. Important to get this in now.

@tylerhutcherson tylerhutcherson marked this pull request as draft December 22, 2023 03:06
@tylerhutcherson tylerhutcherson removed the request for review from Spartee December 22, 2023 03:06
@tylerhutcherson tylerhutcherson changed the base branch from main to dev December 22, 2023 03:06
@tylerhutcherson tylerhutcherson marked this pull request as ready for review December 22, 2023 03:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@4402ac1). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #93   +/-   ##
======================================
  Coverage       ?   77.92%           
======================================
  Files          ?       21           
  Lines          ?     1309           
  Branches       ?        0           
======================================
  Hits           ?     1020           
  Misses         ?      289           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerhutcherson tylerhutcherson merged commit 78843eb into dev Jan 11, 2024
18 checks passed
@tylerhutcherson tylerhutcherson deleted the return-keys-load branch January 11, 2024 15:27
Spartee pushed a commit that referenced this pull request Jan 19, 2024
Returns the list of keys written to redis on load/write.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants