Integrate VoyageAI Vectorizer and Reranker class #223
Conversation
|
@tylerhutcherson Thank you very much! Please let me know if i can help you with this. |
|
@tylerhutcherson It seems like there is an error in the rerank code, i suggested a change: https://github.com/redis/redis-vl-python/pull/223/files#r1777636350 |
|
@fzowl We are so close. I am having a hard time getting this to work with |
| if isinstance(avectorizer, VoyageAITextVectorizer): | ||
| embeddings = await avectorizer.aembed_many(texts) | ||
| else: | ||
| embeddings = await avectorizer.aembed_many(texts) |
There was a problem hiding this comment.
why is this if-else block needed?
There was a problem hiding this comment.
Not sure, will remove
There was a problem hiding this comment.
@justin-cechmanek Yeah, seems like a mistake. Sorry about that. (i think originally i was planning to add further parameters, but in its state this condition is not needed)
| if isinstance(avectorizer, VoyageAITextVectorizer): | ||
| embedding = await avectorizer.aembed(text) | ||
| else: | ||
| embedding = await avectorizer.aembed(text) |
There was a problem hiding this comment.
same question, why do we need this if-else?
There was a problem hiding this comment.
@justin-cechmanek Same as above, looks like a mistake
|
@tylerhutcherson @justin-cechmanek Is there a way i can help with this one? I'd happily remove those if-else statements, but i can't push to this PR. |
|
We resolved some of our CI/CD issues (due to a buggy |
Reformatting Adding VoyageAI to enum
tylerhutcherson
force-pushed
the
feat/RAAE-127/voyage-ai-integration
branch
from
5a80260 to
516fd33
Compare
This PR (thanks to @fzowl) integrates the VoyageAI vectorizer and reranker into the RedisVL client, streamlining access for devs to embed data and rerank search results from Redis.