Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to contributions page #108

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Changes to contributions page #108

merged 2 commits into from
Feb 1, 2024

Conversation

bsbodden
Copy link
Collaborator

@bsbodden bsbodden commented Feb 1, 2024

  • Highlight the need for REDIS_URL env var
  • Add quotes around pip install -e for compatibility with all shells

@bsbodden bsbodden self-assigned this Feb 1, 2024
@tylerhutcherson tylerhutcherson added the documentation Improvements or additions to documentation label Feb 1, 2024
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (727cd76) 78.92% compared to head (28d73b2) 78.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files          25       25           
  Lines        1476     1476           
=======================================
  Hits         1165     1165           
  Misses        311      311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerhutcherson tylerhutcherson merged commit 16c11e2 into main Feb 1, 2024
20 of 36 checks passed
@tylerhutcherson tylerhutcherson deleted the bsb/misc-contribs branch February 1, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants