Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command for resource deletion #25

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Added command for resource deletion #25

merged 3 commits into from
Sep 23, 2024

Conversation

RishabhKodes
Copy link
Collaborator

  • Added a command for deleting all the resources present in a resource-group. (the resource-group itself does not get deleted).
  • Suggesting a fix for the appending aro to the resource-group-delete. Because all the other commands have aro appended to them, therefore we should maintain uniformity.

Signed-off-by: RishabhKodes <rishabhbhandari6@gmail.com>
Signed-off-by: RishabhKodes <rishabhbhandari6@gmail.com>
Copy link
Collaborator

@kksat kksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes

Copy link
Contributor

@mjiao mjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: RishabhKodes <rishabhbhandari6@gmail.com>
@kksat kksat merged commit 121e58a into main Sep 23, 2024
3 checks passed
@kksat kksat deleted the resourcesdeletion branch September 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants