Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aro cluster name to the aro domain #22

Merged
merged 1 commit into from
Aug 27, 2024
Merged

add aro cluster name to the aro domain #22

merged 1 commit into from
Aug 27, 2024

Conversation

mjiao
Copy link
Contributor

@mjiao mjiao commented Aug 27, 2024

No description provided.

@mjiao mjiao requested a review from kksat August 27, 2024 12:01
add aro cluster name to the aro domain
0a7bdfc 
Signed-off-by: c5346650 <manjun.jiao@sap.com>
kksat
kksat approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@kksat kksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

I remember that I had some issues with domain records while developing.

Just need your confirmation that you tested it, after that will merge.

@mjiao
Copy link
Contributor Author

mjiao commented Aug 27, 2024

This looks great.

I remember that I had some issues with domain records while developing.

Just need your confirmation that you tested it, after that will merge.

Thanks for reviewing. Yes, I tested that and it works correctly.

@kksat kksat merged commit 0973d67 into redhat-sap:main Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kksat kksat kksat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjiao @kksat