Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Setuid/Setgid bits to be removed #1236

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

bcrochet
Copy link
Contributor

Removal of setuid/setgid bits should be allowed, as this can be seen only as increasing security. Caveat emptor should this removal cause a workload to subsequently fail.

@openshift-ci openshift-ci bot requested review from jomkz and skattoju January 10, 2025 19:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@coveralls
Copy link

coveralls commented Jan 10, 2025

Coverage Status

coverage: 84.654% (+0.04%) from 84.619%
when pulling f526dfb on bcrochet:uidgidbits
into 24a1412 on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Jan 10, 2025

@dcibot
Copy link

dcibot commented Jan 28, 2025

Removal of setuid/setgid bits should be allowed, as this can be seen
only as increasing security. Caveat emptor should this removal cause
a workload to subsequently fail.

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@dcibot
Copy link

dcibot commented Jan 30, 2025

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit bec6343 into redhat-openshift-ecosystem:main Jan 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants