Add certification-component-id flag #1222
Merged
+146
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
from change #1222: |
acornett21
reviewed
Dec 9, 2024
bcrochet
force-pushed
the
fixes/1185
branch
2 times, most recently
from
36ccf2f to
8de58b7
Compare
|
from change #1222: |
|
/test 4.17-e2e |
acornett21
reviewed
Dec 10, 2024
acornett21
approved these changes
Dec 10, 2024
|
from change #1222: |
|
from change #1222: |
|
/test 4.17-e2e |
komish
requested changes
Jan 31, 2025
Comment on lines
+237
to
+240
| // However, if the new env var is set, that's the priority | ||
| if viper.IsSet("certification_component_id") { | ||
| viper.Set("certification_project_id", viper.GetString("certification_component_id")) | ||
| } |
There was a problem hiding this comment.
Is this only necessary because certification_component_id is bound explicitly to env, separate from the global variable?
This flag deprecates the certification-project-id flag. The field has been changed on the server side, and in certification documentation. Fixes redhat-openshift-ecosystem#1185 Signed-off-by: Brad P. Crochet <brad@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
from change #1222: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag deprecates the certification-project-id flag. The field has been changed on the server side, and in certification documentation.
Fixes #1185