Improved grammar for kotlin based on official documentation #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Per-Steinar Karlsen <per-steinar.karlsen@skatteetaten.no>
|
As long as we've made an attempt to upstream the work, at eclipse-buildship/buildship#1273, I'm fine with getting it in here sooner. @jdneo , feel free to merge if it all looks good to you. |
|
Hi @per-steinar, thank you for your contribution! Looks like lots of cases will be improved with this PR. If possible, would you mind give the improved sample snippets as comment here? |
|
@jdneo Most of the changes are only vissible when inspecting the textmate scopes, but i have added the most vissible ones:
|
Signed-off-by: Per-Steinar Karlsen <per-steinar.karlsen@skatteetaten.no>
jdneo
approved these changes
Dec 5, 2023
|
Thank you @per-steinar! |
fwcd
reviewed
Jan 15, 2024
| @@ -21,10 +21,13 @@ | |||
| ], | |||
| "repository": { | |||
| "import": { | |||
| "begin": "\\b(import)\\b\\s*", | |||
| "begin": "\\b(import)\\b\\s?([\\w+.]*\\w+)?\\s*", | |||
There was a problem hiding this comment.
This rule unfortunately isn't quite correct and matches the package name as a modifier token, see: fwcd/vscode-kotlin#137 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR improves kotlin grammar based on documentation from https://kotlinlang.org/docs/home.html
Resolves #3403