Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Java settings by categories #3386

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

testforstephen
Copy link
Collaborator

@testforstephen testforstephen commented Nov 10, 2023

What it does in this PR:

  • Group the settings by categories, this can make it easier to navigate the settings through the settings UI. The category display order is based on the development E2E workflow.
    image

  • Adjust the display order for the settings instead of alphabetical order.

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen testforstephen marked this pull request as ready for review November 13, 2023 02:51
@testforstephen testforstephen linked an issue Nov 13, 2023 that may be closed by this pull request
@rgrunber rgrunber modified the milestone: End November 2023 Nov 13, 2023
@rgrunber
Copy link
Member

rgrunber commented Nov 13, 2023

  • Do you feel it's worth creating a category called References to contain java.implementationsCodeLens.enabled, java.inlayHints.parameterNames.enabled, java.inlayHints.parameterNames.exclusions, java.references.includeAccessors, java.references.includeDecompiledSources, java.referencesCodeLens.enabled, java.symbols.includeSourceMethodDeclarations ? Or did you want to reduce the number of categories and since very few are explicitly "reference" related, it made sense to leave them as Others for now ?
  • Thoughts on putting java.edit.smartSemicolonDetection.enabled under "Code Generation" ?

Overall, I think this is nicely organized.

@testforstephen
Copy link
Collaborator Author

  • Do you feel it's worth creating a category called References to contain java.implementationsCodeLens.enabled, java.inlayHints.parameterNames.enabled, java.inlayHints.parameterNames.exclusions, java.references.includeAccessors, java.references.includeDecompiledSources, java.referencesCodeLens.enabled, java.symbols.includeSourceMethodDeclarations ? Or did you want to reduce the number of categories and since very few are explicitly "reference" related, it made sense to leave them as Others for now ?

How about adding a new category Code Navigation instead of References?

  • Thoughts on putting java.edit.smartSemicolonDetection.enabled under "Code Generation" ?

Sure, it's ok.

@testforstephen
Copy link
Collaborator Author

In the latest commit:

  • Add new category "Code Navigation" with children settings such as
    • "java.referencesCodeLens.enabled"
    • "java.implementationsCodeLens.enabled"
    • "java.references.includeAccessors"
    • "java.references.includeDecompiledSources"
    • "java.symbols.includeSourceMethodDeclarations"
    • "java.typeHierarchy.lazyLoad"
    • "java.inlayHints.parameterNames.enabled"
    • "java.inlayHints.parameterNames.exclusions".
  • Move "java.edit.smartSemicolonDetection.enabled" to "Code Generation"
  • Move "java.signatureHelp.enabled" and "java.signatureHelp.description.enabled" to "Code Completion" since signature help is more related with code completion behavior.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with merging this so feel free to do so whenever you're ready.

@rgrunber rgrunber modified the milestone: End November 2023 Nov 15, 2023
@testforstephen testforstephen merged commit b1d0831 into redhat-developer:master Nov 16, 2023
@testforstephen testforstephen deleted the jinbo_settings branch November 16, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorize the extension settings
2 participants