Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java grammar, including the addition of textblocks and fixes for the 'throws' and 'new' keywords #121

Closed

Conversation

hopehadfield
Copy link

Updating based on language-support/java/java.tmLanguage.json. The grammar is now owned there as per discussion at microsoft/vscode#187725 (comment).

The following changes are included:

…or the 'throws' and 'new' keywords

Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@mickaelistria
Copy link
Collaborator

I don't think we should provide the grammar in eclipseide-jdtls any more. The TM4E project has https://github.com/eclipse/tm4e/tree/main/org.eclipse.tm4e.language_pack/java which does provide the grammar (which directly pulls from vscode repo). So instead of maintaining 2 copies, we'd rather remove textmate grammar from here and make com.redhat.eclipseide.jdtls bundle define a requirement on org.eclipse.tm4e.language_pack.

@mickaelistria
Copy link
Collaborator

I've submitted #122 which does defer the issue to TM4E.

@rgrunber
Copy link
Member

rgrunber commented Dec 13, 2023

... https://github.com/eclipse/tm4e/tree/main/org.eclipse.tm4e.language_pack/java which does provide the grammar (which directly pulls from vscode repo).

... and VS Code now fetches from vscode-java 😉 (The original repo has been archived)

@hopehadfield , I would create a direct PR for updating the grammar in https://github.com/eclipse/tm4e and referencing how vscode-java became the main source.

@mickaelistria
Copy link
Collaborator

I would create a direct PR for updating the grammar in https://github.com/eclipse/tm4e and referencing how vscode-java became the main source.

I think TM4E does already fetch from VSCode. I think it's better to keep things simpler and stick to vscode, even if it causes a 1-month delay in the update.

@rgrunber
Copy link
Member

Fair enough. They may just need a heads-up though. Last update was in 2022, https://github.com/eclipse/tm4e/commits/main/org.eclipse.tm4e.language_pack/java/java.tmLanguage.json .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants