Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use a separated external DHCP server #304

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lautou
Copy link
Contributor

@lautou lautou commented Jan 23, 2023

No description provided.

@lautou lautou changed the title Fix syntax error issue when setting critical services Ability to use a separated external DHCP server Jan 23, 2023
@lautou
Copy link
Contributor Author

lautou commented Jan 25, 2023

@christianh814 can we merge this?
we added the possibility to use an external DHCP

@clnperez
Copy link

i'm interested in this as well. for now i just use the static flag since i have an external DHCP server. but how are you dealing with the dns entries? are you using a dhcp server but with a set of pre-allocated IPs you can ask the DHCP server to assign at node-creation?

@christianh814
Copy link
Contributor

christianh814 commented Aug 10, 2023

hey @lautou and @clnperez I'm no longer at Red Hat and I've given control over to @Prajyot-Parab

@Prajyot-Parab
Copy link
Collaborator

Prajyot-Parab commented Aug 10, 2023

@clnperez I will take a look at this one, and do a test run to verify by tomorrow.

Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error -

fatal: [x.x.x.x]: FAILED! => {"msg": "The conditional check 'not staticips and not externaldhcp' failed. The error was: error while evaluating conditional (not staticips and not externaldhcp): 'externaldhcp' is undefined. 'externaldhcp' is undefined\n\nThe error appears to be in '/root/ocp4-helpernode/tasks/set_facts_.yaml': line 19, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n  - set_fact:\n    ^ here\n"}
diff --git a/vars/main.yml b/vars/main.yml
index f8da4f4..f315c03 100644
--- a/vars/main.yml
+++ b/vars/main.yml
@@ -1,8 +1,9 @@
 ---
 ssh_gen_key: true
 ipi: false
 baremetal: true
 staticips: false
+externaldhcp: false

@lautou you need to define externaldhcp var in vars/main.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants