Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvme fix #54

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Nvme fix #54

merged 8 commits into from
Jan 16, 2024

Conversation

swapdisk
Copy link
Member

This fixes #48.

  • Remove bad parenthesis in bigboot.sh that were the root cause of the "device not found" error.
  • Shorten bigboot.sh usage help message to not exceed the kmsg buffer.
  • Add "partition move is progressing" messages so inpatient operators don't think their server is hung while the sfdisk --move-data is running.
  • Fix "vgs not found" error I uncovered while testing.

@swapdisk swapdisk requested a review from ygalblum January 11, 2024 22:55
Copy link
Collaborator

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. I don't remember why I added the parenthesis to begin with.
Other than the comment about the usage LGTM

Copy link
Collaborator

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapdisk swapdisk merged commit f264c5d into redhat-cop:main Jan 16, 2024
15 checks passed
@swapdisk swapdisk deleted the nvme_fix branch January 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure using bigboot with nvme block devices
2 participants